Improve error messaging if no Kibana endpoint is configured. #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two issues that lead to confusing errors being shown: - The `agent_policy` resource did not throw an error if getting the stack version fails - When getting the stack version fails, it only returned the http connection error, not actually stating what it was trying to do. In combination this will now lead to an error like ``` Error: failed to get version from Kibana API. Please ensure a working 'kibana' endpoint is configured. Error: Get "http://localhost:5601/api/status": dial tcp [::1]:5601: connect: connection refused ``
gigerdo
force-pushed
the
improve-error-for-kibana-version
branch
from
a3d64ed to
91a174e
Compare
|
@gigerdo are you able to add a change log entry for this too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues that lead to confusing errors being shown:
agent_policyresource did not throw an error if getting the stack version failsIn combination this will now lead to an error like